Add areaOfInterest and detectObject to CV API #4771
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "parameters": { | ||
| "Endpoint": "https://westus.api.cognitive.microsoft.com", | ||
| "Ocp-Apim-Subscription-Key": "{API key}", | ||
| "Image": "{binary}" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "objects": [ | ||
| { | ||
| "rectangle": { | ||
| "x": 0, | ||
| "y": 0, | ||
| "w": 50, | ||
| "h": 50 | ||
| }, | ||
| "object": "tree", | ||
| "confidence": 0.9, | ||
| "parent": { | ||
| "object": "plant", | ||
| "confidence": 0.95 | ||
| } | ||
| } | ||
| ], | ||
| "requestId": "1ad0e45e-b7b4-4be3-8042-53be96103337", | ||
| "metadata": { | ||
| "width": 100, | ||
| "height": 100, | ||
| "format": "Jpeg" | ||
|
There was a problem hiding this comment. Just an idea, wouldn't There was a problem hiding this comment. I agree, but for all the of other services it's There was a problem hiding this comment. Just curious, what services you are referring to? I searched before and didn't find anyother.. There was a problem hiding this comment. Oh you mean other |
||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "parameters": { | ||
| "Endpoint": "https://westus.api.cognitive.microsoft.com", | ||
| "Ocp-Apim-Subscription-Key": "{API key}", | ||
| "ImageUrl": "{url}" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "objects": [ | ||
| { | ||
| "rectangle": { | ||
| "x": 0, | ||
| "y": 0, | ||
| "w": 50, | ||
| "h": 50 | ||
| }, | ||
| "object": "tree", | ||
| "confidence": 0.9, | ||
| "parent": { | ||
| "object": "plant", | ||
| "confidence": 0.95 | ||
| } | ||
| } | ||
| ], | ||
| "requestId": "1ad0e45e-b7b4-4be3-8042-53be96103337", | ||
| "metadata": { | ||
| "width": 100, | ||
| "height": 100, | ||
| "format": "Jpeg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "parameters": { | ||
| "Endpoint": "https://westus.api.cognitive.microsoft.com", | ||
| "Ocp-Apim-Subscription-Key": "{API key}", | ||
| "Image": "{binary}" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "areaOfInterest": { | ||
| "h": 951, | ||
| "w": 950, | ||
| "x": 160, | ||
| "y": 0 | ||
| }, | ||
| "requestId": "ed2de1c6-fb55-4686-b0da-4da6e05d283f", | ||
| "metadata": { | ||
| "format": "Jpeg", | ||
| "height": 951, | ||
| "width": 1378 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "parameters": { | ||
| "Endpoint": "https://westus.api.cognitive.microsoft.com", | ||
| "Ocp-Apim-Subscription-Key": "{API key}", | ||
| "ImageUrl": "{url}" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "areaOfInterest": { | ||
| "h": 951, | ||
| "w": 950, | ||
| "x": 160, | ||
| "y": 0 | ||
| }, | ||
| "requestId": "ed2de1c6-fb55-4686-b0da-4da6e05d283f", | ||
| "metadata": { | ||
| "format": "Jpeg", | ||
| "height": 951, | ||
| "width": 1378 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a breaking change for your API - current SDKs will not be able to handle these new enums. Only enums with "modelAsString" set to true are allowed to add new enum values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help clarify? If the service returns one of these new values in the JSON, aren't current clients screwed anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianghaolu Any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes That's what I mean by saying the rest API is going to break the clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't justify breaking the clients after breaking the APIs. If this list is supposed to grow you should mark "modelAsString" to true in this PR. This PR is bringing breaking changes anyways (unfortunately) but there will be no more in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to true to prevent future breaking changes. Also in here.