Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in old Network API version #4940

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix errors in old Network API version #4940

merged 1 commit into from
Jan 7, 2019

Conversation

anton-evseev
Copy link
Contributor

Fixed validation errors:

  • OBJECT_MISSING_REQUIRED_PROPERTY_DEFINITION
    • Remove property nextHopType from required as there was no such property in definition
  • EQUIVALENT_PATH
    • Put get and put under one path

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#904

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2125

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@anton-evseev anton-evseev mentioned this pull request Dec 18, 2018
Closed
@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3812

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4516

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2591

jianghaolu
jianghaolu reviewed Dec 19, 2018
View reviewed changes
specification/network/resource-manager/Microsoft.Network/stable/2016-03-30/network.json
@@ -3282,45 +3282,6 @@
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{connectionSharedKeyName}/sharedkey": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why breaking this functionality in the old api version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not breaking, there are two duplicate paths in old specs, one with PUT and one with GET, so I'm moving them under one entry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! Then it's fine

@jianghaolu
Copy link
Contributor

Sorry I missed your comment during the holidays. Please reopen and target january-network-release and assign to me. Thanks!

@jianghaolu jianghaolu closed this Jan 4, 2019
@kpajdzik kpajdzik removed the review label Jan 4, 2019
@MikhailTryakhov MikhailTryakhov changed the base branch from december-network-release to master January 4, 2019 06:40
@MikhailTryakhov
Copy link
Contributor

@jianghaolu it need to be merged ASAP. In master in this case. Please remove january-network-release - I create branches myself :)

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@kpajdzik kpajdzik added the review label Jan 4, 2019
This was referenced Jan 7, 2019
Merged
Merged
Closed
Merged
@anton-evseev
Copy link
Contributor Author

@jianghaolu @MikhailTryakhov rebased PR against master, please take a look

@AutorestCI AutorestCI mentioned this pull request Jan 7, 2019
Merged
@jianghaolu jianghaolu merged commit 63a1143 into Azure:master Jan 7, 2019
@kpajdzik kpajdzik removed the review label Jan 7, 2019
@AutorestCI AutorestCI mentioned this pull request Jan 7, 2019
Merged
@MikhailTryakhov
Copy link
Contributor

@number213 please merge it to january branch as well

@nschonni
Copy link
Contributor

nschonni commented Jan 8, 2019

Looks like this issue might be in the 2015-06-15 files as well https://travis-ci.org/Azure/azure-rest-api-specs/jobs/476680029#L690-L706

@anton-evseev anton-evseev deleted the old-vpngw-fix branch January 8, 2019 07:30
This was referenced Jan 8, 2019
Merged
Merged
@anton-evseev
Copy link
Contributor Author

Nick's right, I missed one API version. Opened PR for it: #5002
Also, ported those changes to January branch: #5003

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@anton-evseev @AnuTalluri
Fix errors in old Network API version (Azure#4940)
3a49501
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@divyansh3131
Adding landing URL in environmentInfo (#4940)
2a10cf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anton-evseev @azuresdkci @AutorestCI @jianghaolu @MikhailTryakhov @nschonni @kpajdzik