Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch for Solution, fix various tests #5796

Merged
merged 3 commits into from May 7, 2019
Merged

add patch for Solution, fix various tests #5796

merged 3 commits into from May 7, 2019

Conversation

dougbrad
Copy link
Contributor

@dougbrad dougbrad commented Apr 30, 2019 •
edited

…and ManagementConfiguration API will be deprecated in future so in a couple of cases removed inputs

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@dougbrad
add patch for Solution, fix various tests, the ManagementAssociation …
e7b2d45 
…and ManagementConfiguration API will be deprecated in future so in a couple of cases removed inputs
@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019 •
edited

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019 •
edited

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Apr 30, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019 •
edited

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2742

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019 •
edited

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Apr 30, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019 •
edited

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4755

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@tjprescott
Copy link
Member

@dougbrad can you elaborate why you opened this as a draft PR?

ericc1103
ericc1103 approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@ericc1103 ericc1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good on PATCH related.

@AutorestCI AutorestCI mentioned this pull request May 3, 2019
Merged
@dougbrad dougbrad changed the title add patch for Solution, fix various tests, the ManagementAssociation … add patch for Solution, fix various tests May 3, 2019
@dougbrad
Copy link
Contributor Author

dougbrad commented May 3, 2019

The OpenAPI tests cannot be run, forever get:
Still working!

@dougbrad dougbrad marked this pull request as ready for review May 3, 2019 00:40
@dougbrad
Copy link
Contributor Author

dougbrad commented May 3, 2019

@dougbrad can you elaborate why you opened this as a draft PR?

@dougbrad dougbrad closed this May 3, 2019
@dougbrad dougbrad reopened this May 3, 2019
@dougbrad
Copy link
Contributor Author

dougbrad commented May 3, 2019

@dougbrad can you elaborate why you opened this as a draft PR?

Hi, it was just so our team could do further review. Should have done that before-hand though.

tjprescott
tjprescott reviewed May 6, 2019
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the response bodies of a lot of examples have been slashed. Is this because the previous examples were incorrect and did not represent the actual service response?

...-manager/Microsoft.OperationsManagement/preview/2015-11-01-preview/OperationsManagement.json Outdated Show resolved Hide resolved
....OperationsManagement/preview/2015-11-01-preview/examples/ManagementConfigurationCreate.json
}
]
}
"location":"East US"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This create requires no parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are non-used API's, created before a re-org. We plan to remove them after doing a little more diligence.
So took quickest rout in order to get the test passing.

@tjprescott tjprescott merged commit 7bbbbb2 into Azure:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@ericc1103 ericc1103 ericc1103 approved these changes

@tjprescott tjprescott tjprescott approved these changes

@paruizfi paruizfi paruizfi approved these changes

Assignees

@tjprescott tjprescott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dougbrad @AutorestCI @azuresdkci @tjprescott @nschonni @ericc1103 @paruizfi