Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the stable api version of Azure Sentinel api #8146

Merged
merged 17 commits into from Feb 12, 2020
Merged

Add the stable api version of Azure Sentinel api #8146

merged 17 commits into from Feb 12, 2020

Conversation

alshulma
Copy link
Contributor 

stable\2020-01-01

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@alshulma alshulma closed this Jan 14, 2020
@alshulma alshulma reopened this Jan 14, 2020
@alshulma alshulma closed this Jan 14, 2020
@alshulma alshulma reopened this Jan 14, 2020
@lirenhe
Copy link
Contributor

lirenhe commented Jan 15, 2020

@alshulma, could you take a look and fix the Avocado and Semantic check errors?

@lirenhe lirenhe added Changes Required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2020
@alshulma alshulma closed this Jan 15, 2020
@alshulma alshulma reopened this Jan 15, 2020
@alshulma alshulma closed this Jan 15, 2020
@alshulma alshulma reopened this Jan 15, 2020
@lirenhe
Copy link
Contributor

lirenhe commented Jan 19, 2020

@alshulma, I still see a couple of tool check error, could you take a look at the LintDiff and PrettierCheck errors?

@alshulma alshulma closed this Jan 19, 2020
@alshulma alshulma reopened this Jan 19, 2020
@alshulma alshulma closed this Jan 20, 2020
@alshulma alshulma reopened this Jan 20, 2020
@alshulma alshulma closed this Jan 20, 2020
@alshulma alshulma reopened this Jan 20, 2020
@alshulma alshulma closed this Jan 20, 2020
@pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 4, 2020
@alshulma alshulma closed this Feb 5, 2020
@alshulma alshulma reopened this Feb 5, 2020
@alshulma alshulma closed this Feb 5, 2020
@alshulma alshulma reopened this Feb 5, 2020
@lirenhe
Copy link
Contributor

lirenhe commented Feb 6, 2020

@alshulma, could you take a look at the error reported by LintDiff?

@alshulma
Copy link
Contributor Author

alshulma commented Feb 6, 2020 via email

@anthony-c-martin
Copy link
Member

@alshulma, could you take a look at the error reported by LintDiff?

@lirenhe, this is actually a perfectly valid use case - Microsoft.SecurityInsights are declaring an extension resource on the Microsoft.OperationalInsights provider. Please could you investigate whether we can add a suppression for R2059 in this case? Please see https://armwiki.azurewebsites.net/introduction/concepts/resourceids.html for some more explanation on what is considered a valid resourceId.

I notice a similar suppression has already been put in place for Microsoft.Consumption: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/readme.md#suppression.

@lirenhe
Copy link
Contributor

lirenhe commented Feb 10, 2020

I see. Thanks @anthony-c-martin. It should be an issue of the Lint tool.
@alshulma, could you add the suppression into the readme file to workaround the tool check failure? You could reference https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/readme.md#suppression.

@alshulma alshulma closed this Feb 10, 2020
@alshulma alshulma reopened this Feb 10, 2020
@alshulma
Copy link
Contributor Author

@lirenhe I've added the suppression into the readme file.

@alshulma alshulma closed this Feb 11, 2020
@alshulma alshulma reopened this Feb 11, 2020
@lirenhe
Copy link
Contributor

lirenhe commented Feb 12, 2020

/azp run automation -sdk

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@lirenhe
Copy link
Contributor

lirenhe commented Feb 12, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lirenhe lirenhe merged commit 8e50493 into Azure:master Feb 12, 2020
ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
@alshulma @ssripadham
Add the stable api version of Azure Sentinel api (Azure#8146)
73c5ecd 
* Add the stable api version of Azure Sentinel api

    stable\2020-01-01

* Add kind as required

* Resolve  Avocado and Semantic check errors

* Edit readme.md

* Change readme.md

* make prettier

* Add default response for operations

* Change version in examples

* Fix version

* Change version

* Add AlertRuleTemplateDataSource and remove tactics

* Fix examples

* change description

* Changed {operationalInsightsResourceProvider} to Microsoft.OperationalInsights

* remove OperationalInsightsResourceProvider

* supress R2059

* Changed name
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@alshulma @00Kai0
Add the stable api version of Azure Sentinel api (Azure#8146)
9335376 
* Add the stable api version of Azure Sentinel api

    stable\2020-01-01

* Add kind as required

* Resolve  Avocado and Semantic check errors

* Edit readme.md

* Change readme.md

* make prettier

* Add default response for operations

* Change version in examples

* Fix version

* Change version

* Add AlertRuleTemplateDataSource and remove tactics

* Fix examples

* change description

* Changed {operationalInsightsResourceProvider} to Microsoft.OperationalInsights

* remove OperationalInsightsResourceProvider

* supress R2059

* Changed name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilor pilor pilor approved these changes

@lirenhe lirenhe lirenhe approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alshulma @AutorestCI @lirenhe @allenjzhang @anthony-c-martin @pilor