-
Notifications
You must be signed in to change notification settings - Fork 29
Add support for StringIO inside body headers #39
Add support for StringIO inside body headers #39
Conversation
There is one IO which doesnt inherit from IO, StringIO. StringIO is especially usefull in testing scenarios
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This partially addressed:
#29
@yaxia 👍, any plans when you are going to merge this. Waiting on this ship 😃 |
@sarangan12 could you please comment on the release plan? Thanks. |
@vishrutshah Please take a look at this PR. In the original issue, you have mentioned to handle IO, File and StringIO. But file is handled only by the else condition. Since you have more context on this issue, I would like you to review |
@dixpac We appreciate your effort in improving the SDK. Thank you so much for the contribution. Changes looks good. Would you mind adding a sample unit test case into http_request_test.rb to make sure going forward no one breaks the expectations, please? Thanks again for taking time to contribute. |
@vishrutshah no problem 👍 |
@vishrutshah there you go I've cover all 3 cases in testes 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Any plans on release(I need this desperately) 😃 . I just added azure support out of the box inside new rails( |
@dixpac Am getting the release today |
@dixpac The release is completed. |
There is one IO which doesn't inherit from IO, StringIO(inherits from Data).
StringIO is especially useful in testing scenarios