Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureBlob sdk: small API inconsistency #19688

Closed
drakkan opened this issue Dec 10, 2022 · 1 comment · Fixed by #19834
Closed

AzureBlob sdk: small API inconsistency #19688

drakkan opened this issue Dec 10, 2022 · 1 comment · Fixed by #19834
Assignees
@siminsavani-msft
Labels
AzBlob Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Milestone
azblob v1.0.0

Comments

@drakkan
Copy link
Contributor

drakkan commented Dec 10, 2022

Feature Request

Hi, this isn't a big deal to me, but since you're frequently breaking the APIs to fix inconsistencies and improve usability, you might want to consider this request.

If you get blob properties like this

https://github.com/drakkan/sftpgo/blob/e2bebc99d1fb7bc03c8cdb215a14318ebc2b6d94/internal/vfs/azblobfs.go#L768

resp.Metadata is map[string]string.

If you get a blob like this

https://github.com/drakkan/sftpgo/blob/e2bebc99d1fb7bc03c8cdb215a14318ebc2b6d94/internal/vfs/azblobfs.go#L479

or this

https://github.com/drakkan/sftpgo/blob/e2bebc99d1fb7bc03c8cdb215a14318ebc2b6d94/internal/vfs/azblobfs.go#L597

the metadata is map[string]*string.

Perhaps the SDK could return the same type in both cases.
Feel free to close this issue as wontfix and thanks for your work
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 10, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

Hi @drakkan. Thank you for your feedback and we will look into it soon. Meanwhile, feel free to share your experience using the Azure SDK in this survey.

@jhendrixMSFT jhendrixMSFT added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Dec 12, 2022
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Dec 12, 2022
@vibhansa-msft vibhansa-msft added this to the azblob v1.0.0-beta milestone Dec 13, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Jan 4, 2023
Merged
@siminsavani-msft siminsavani-msft mentioned this issue Jan 18, 2023
Merged
5 tasks
@vibhansa-msft vibhansa-msft linked a pull request Jan 19, 2023 that will close this issue
Update autorest version to Preview.45 #19834
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siminsavani-msft siminsavani-msft

Labels
AzBlob Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azblob v1.0.0
Development

Successfully merging a pull request may close this issue.

Update autorest version to Preview.45 Azure/azure-sdk-for-go
4 participants
@drakkan @jhendrixMSFT @vibhansa-msft @siminsavani-msft