Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnet struct does not support the routeTable property #224

Closed
vgarg opened this issue Oct 7, 2015 · 8 comments
Closed

Subnet struct does not support the routeTable property #224

vgarg opened this issue Oct 7, 2015 · 8 comments

Comments

@vgarg
Copy link

vgarg commented Oct 7, 2015

As per the documentation at [1] the the properties JSON for a subnet looks as follows:

{ 
   "properties":{ 
      "addressPrefix":"10.1.0.0/24",
      "networkSecurityGroup":{ 
         "id":"/subscriptions/{guid}/../microsoft.network/networkSecurityGroups/myNSG1"
      },
    "routeTable": { "id": "/subscriptions/{guid}/../Microsoft.Network/routeTables/myRT1" }
   }
}

We know this approach works as we have used the same approach within an ARM template.

Now we have a need to create another subnet at runtime and I am using the GO SDK to do so. However there does not appear to be a way to specify the routeTable for the subnet using the SDK.

On our end, we need the fix urgently. For now I guess I could just hack the SDK and add the missing property in the Subnet struct. Does that sound like something that would work?

[1] https://msdn.microsoft.com/en-us/library/azure/mt163621.aspx

@brendandixon
Copy link
Contributor

@vgarg I took a quick look at the Swagger that backs the SDK (see https://github.com/Azure/azure-rest-api-specs). I could find no references to "routeTable" in the arm-network Swagger. Could you, please, look it over as well? You are likely more familiar with the Network ARM templates than I am.

@devigned @vgarg's issue appears to be a Swagger problem.

@vgarg
Copy link
Author

vgarg commented Oct 7, 2015

@brendandixon Indeed, I see no mention of routeTable in the swagger JSON. Looks like the swagger JSON and the actual REST API documentation are out of sync. Or perhaps the routeTable property is new, and did not cause a version change?

@brendandixon
Copy link
Contributor

@vgarg Unclear. Let me follow-up with @devigned as he oversees the Swagger.

@brendandixon
Copy link
Contributor

@vgarg It looks like the ARM Network Swagger was recently updated. It now includes the routeTable. See https://github.com/Azure/azure-rest-api-specs/blob/master/arm-network/2015-05-01-preview/swagger/network.json#L6039. We're working an update to the ARM packages that will include these changes.

@devigned
Copy link
Member

@brendandixon we need to automate the codegen pipeline... We should talk about this soon.

@brendandixon
Copy link
Contributor

@devigned Sounds good to me. :)

@brendandixon
Copy link
Contributor

@vgarg This is addressed in the v0.2.0-beta version of the ARM packages.

@ahmetb ahmetb closed this as completed Mar 7, 2016
@ahmetb
Copy link
Contributor

ahmetb commented Mar 7, 2016

Apparently fixed, closing.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants