New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service Client should poll for HTTP the status code 429 #884

Closed
tombuildsstuff opened this Issue Dec 4, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@tombuildsstuff
Contributor

tombuildsstuff commented Dec 4, 2017

馃憢馃徎

We've had an issue come in where the following retry-able error is being retuned from the Azure API but isn't automatically retried by the SDK. Here's the error:

web.AppServicePlansClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Put https://management.azure.com/subscriptions/eXXXXXX-cXXX-4XXX-bXXX-dXXXXXX/resourceGroups/agid-rg-test/providers/Microsoft.Web/serverfarms/agid-app-test?api-version=2016-09-01: http: ContentLength=131 with Body length 0

and the associated message from the logs:

Cannot acquire exclusive lock to create or update this server farm. Retry the request later.`

After asking the requestor for more information, it appears that a HTTP 429 is being returned from the Azure API but not exposed/polled for in the SDK: https://gist.github.com/gunzip/46e32eedaaedf57902195e8a4ec634c9

Whilst I'm aware the Web API's are a little different to the rest of the Azure API's (insofar as they don't necessarily match the Status Codes usages returned by the other API's) - would it be possible to look into polling for this Status Code?

Thanks!

@jhendrixMSFT

This comment has been minimized.

Show comment
Hide comment
@jhendrixMSFT

jhendrixMSFT Dec 7, 2017

Member

This looks related to Azure/go-autorest#214

Member

jhendrixMSFT commented Dec 7, 2017

This looks related to Azure/go-autorest#214

@jhendrixMSFT

This comment has been minimized.

Show comment
Hide comment
@jhendrixMSFT

jhendrixMSFT Dec 9, 2017

Member

@tombuildsstuff this should be fixed in v9.5.1 of go-autorest. Please re-open if you can still repro this issue with that version all I'll investigate further.

Member

jhendrixMSFT commented Dec 9, 2017

@tombuildsstuff this should be fixed in v9.5.1 of go-autorest. Please re-open if you can still repro this issue with that version all I'll investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment