Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for unlimited storage document collections #114

Merged
merged 16 commits into from
Mar 18, 2019

Conversation

ftchirou
Copy link

@ftchirou ftchirou commented Feb 10, 2019

Fixes #107 and #108.

Changes Proposed in this pull request:

  • Change the Document class into a protocol requiring a partition key and an id
  • Update the AzureData API functions to add partition key parameters where needed
  • Remove DictionaryDocument
  • Update the tests
  • Remove the last Objective-C references and the AzureData ObjC target
  • Update the docs

- Change the Document class into a protocol requiring a partition key and an id
- Update API functions to support partition key parameters where needed
- Remove DictionaryDocument
- Update the tests
AzureData/Source/AzureData.swift Outdated Show resolved Hide resolved
AzureData/Source/AzureDataExtensions.swift Outdated Show resolved Hide resolved
AzureData/Source/DocumentClient.swift Show resolved Hide resolved
AzureData/Source/AzureData.swift Outdated Show resolved Hide resolved
AzureData/Source/AzureData.swift Outdated Show resolved Hide resolved
Copy link
Member

@NateRickard NateRickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants