Add AzureTest framework #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency for AzureTest.
* Update DVR references to point to fork rather than venmo. * Remove static linkage to DVR.
…nto feature/AzureTest
* Environment Variable for sdk root * Revert project.pbxproj * Edit to outputDirectory construction
…nto feature/AzureTest
* Environment Variable for sdk root Enforce that DVR record-playback honors environment variables * Environment Variables work as intended with the new DVR updates * Undo Podfile Changes Local Changes that need to be removed * Slight edit to record mode Co-authored-by: Jair Myree <t-jairmyree@microsoft.com>
* Add resource group delete operation. * Progress. * Project setting fixes. * Add test-resources.bicep file. * Update bicep file. * Target python script in test resource deploy post-script. * Remove ResourceUtil files and dependencies. * Revert to previous output style.
…o feature/AzureTest
…o feature/AzureTest
…o feature/AzureTest
* Commit test-settings.plist and git-ignore. * TestSettings protocol. * Update Podfile for DVR * Don't use local DVR * Chat test updates. * Add recordings to project. * Update prepare_chat_tests.py * Update deployment targets. * Add podspec. * Add readme. * Fix hard-coded links.
…o feature/AzureTest
* Remove headers. * Add scrubbed recordings.
…o feature/AzureTest # Conflicts: # sdk/communication/AzureCommunicationChat/AzureCommunicationChat.xcodeproj/project.pbxproj
* Major edits toward scrubbing subscription IDs * Minor edits on scrubbing * Update sdk/test/AzureTest/Scrubbing.swift Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com> * Update sdk/test/AzureTest/Scrubbing.swift Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com> * Update sdk/test/AzureTest/Scrubbing.swift Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com> * Update sdk/test/AzureTest/Scrubbing.swift Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com> * Recommit: Files changes got left out of last commit * Requested Draft PR changes * Clean up after rebase * Testing response scrubbing in progress * Finished Scrubbing SubscriptionIDs * Adjustments made to PR based on review comments. * Edits to PR based on review comments * Update sdk/test/AzureTest/AzureTestTests/AzureTestTests.swift Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com> * More edits based of pr review * More edits to pr based off of review comments * More edits to PR based off suggestions in review * More edits to PR from review comments * Removed unused functions and extensions * Edits to PR based off review comments * Edits to PR from review comments * Edits based off PR review comments Co-authored-by: Jair Myree <t-jairmyree@microsoft.com> Co-authored-by: Travis Prescott <tjprescott@users.noreply.github.com>
…o feature/AzureTest
* Add base class for recordable tests. * Run swiftformat.
tjprescott
requested review from
benbp,
mayurid,
sacheu,
weshaggard and
a team
as code owners
ghost
added
the
tjprescott
force-pushed
the
feature/AzureTest
branch
from
57ec740
to
827ad96
Compare
|
This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:
|
benbp
reviewed
Jul 26, 2021
| @@ -5,36 +5,49 @@ | |||
|
|
|||
There was a problem hiding this comment.
Would this file be better placed in the ACS service directory?
There was a problem hiding this comment.
That's what I would have preferred if I could have used test-resources-post.py. Absent that, I don't want to clutter the service directory and figured it would be best to keep this in the "normal" spot under eng/scripts.
benbp
reviewed
Jul 26, 2021
| key = "AZURE_COMMUNICATION_USER_ID_2" | ||
| value = "" | ||
| key = "SDK_REPO_ROOT" | ||
| value = "/Users/travisprescott/repos/azure-sdk-for-ios" |
There was a problem hiding this comment.
I assume this shouldn't be your windows user path?
There was a problem hiding this comment.
This is my Mac user directory and yes, it is intentional. Anyone who wants to run the test would need to update this with their own settings, but since the build artifact isn't "aware" of the source directory, it (seemingly) has to be hard coded like this for the recording functionality to work correctly.
…o feature/AzureTest # Conflicts: # sdk/communication/AzureCommunicationChat/AzureCommunicationChat.xcodeproj/project.pbxproj
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AzureTest for creating record/playback style tests. Add RecordableXCTestCase to make it easier to add recordable tests.
Documentation provided here:
https://github.com/Azure/azure-sdk-for-ios/wiki/Writing-End-to-End-Tests-using-AzureTest