Fix no network statsbeat (#37360)

* Fix network statsbeat not triggered * Default to standalone_auto * Update changelog * Address comments * Rename a feature * Fix checkstyle
Azure · Oct 25, 2023 · f19539a · f19539a
1 parent df52c89
commit f19539a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md b/sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Bugs Fixed
 - [Fix null ikey for _otelresource_ custom metrics](https://github.com/Azure/azure-sdk-for-java/pull/37352)
+- [Fix no network statsbeat](https://github.com/Azure/azure-sdk-for-java/pull/37360)
 
 ## 1.0.0-beta.12 (2023-10-23)
 

diff --git a/.../main/java/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/Feature.java b/.../main/java/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/Feature.java
@@ -66,7 +66,7 @@ public enum Feature {
     PREVIEW_GENERAL_EXPORT_QUEUE_CAPACITY(51), // track generalExportQueueCapacity
     PREVIEW_METRICS_EXPORT_QUEUE_CAPACITY(52), // track metricsExportQueueCapacity
     PREVIEW_DISK_PERSISTENCE_MAX_SIZE_MB(53), // track diskPersistenceMaxSizeMb
-    PREVIEW_USE_NORMALIZED_VALUE_FOR_NON_NORMALIZED_CPU_PERCENTAGE(54), // track useNormalizedValueForNonNormalizedCpuPercentage
+    PREVIEW_DONT_USE_NORMALIZED(54), // track useNormalizedValueForNonNormalizedCpuPercentage
     PREVIEW_CUSTOM_INSTRUMENTATION(55); // track customInstrumentation
 
     private static final Map<String, Feature> javaVendorFeatureMap;

diff --git a/...va/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/StatsbeatModule.java b/...va/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/StatsbeatModule.java
@@ -45,7 +45,8 @@ public StatsbeatModule(Consumer<MetadataInstanceResponse> vmMetadataServiceCallb
         featureStatsbeat = new FeatureStatsbeat(customDimensions, FeatureType.FEATURE);
         instrumentationStatsbeat = new FeatureStatsbeat(customDimensions, FeatureType.INSTRUMENTATION);
         azureMetadataService = new AzureMetadataService(attachStatsbeat, customDimensions, vmMetadataServiceCallback);
-        if (RpAttachType.getRpAttachType() == RpAttachType.MANUAL) {
+        // TODO (heya) will update this when we have a consensus from other languages on what other telemetry to be collected
+        if (RpAttachType.getRpAttachType() != RpAttachType.MANUAL) {
             networkStatsbeat = new NetworkStatsbeat(customDimensions);
             nonessentialStatsbeat = new NonessentialStatsbeat(customDimensions);
         } else {