Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce abstractions over Reactor API #24530

Closed
JonathanGiles opened this issue Oct 4, 2021 · 2 comments
Closed

Introduce abstractions over Reactor API #24530

JonathanGiles opened this issue Oct 4, 2021 · 2 comments
Labels
Azure.Core.V2 Contains issues to consider when desiging Azure Core V2 Azure.Core azure-core breaking-change Client This issue points to a problem in the data-plane of the library. compat breaks

Comments

@JonathanGiles
Copy link
Member

JonathanGiles commented Oct 4, 2021

We might consider abstracting away Mono / Flux types with our own types. The premise of this being that if we control an abstraction, we might be able to shelter users from breaking changes in the Reactor APIs. We could conceivably even change implementations of our async implementation without impacting the user.

The downside of this is obviously the amount of work required to build our own APIs, and to ensure that these APIs can work over multiple implementations (e.g. Reactor3, Reactor4, RxJava (as a proof of concept more than anything), CompletableFuture, Virtual Threads, etc).

If we did consider investigating this further, we could extend this investigation by looking into removing reactor from azure-core, and to introduce a pluggable mechanism in much the same way as we do HTTP clients, etc today.

@JonathanGiles JonathanGiles created this issue from a note in Azure Core V2 (To consider) Oct 4, 2021
@JonathanGiles JonathanGiles changed the title Remove direct dependency on Reactor Introduce abstractions over Reactor API Oct 4, 2021
@JonathanGiles JonathanGiles added Azure.Core azure-core Azure.Core.V2 Contains issues to consider when desiging Azure Core V2 breaking-change Client This issue points to a problem in the data-plane of the library. compat breaks labels Oct 4, 2021
@stliu
Copy link
Member

stliu commented Oct 9, 2021

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Jun 25, 2023
Update readme.java.md to make Resource.resourcegroup  and subscriptionid readonly (Azure#24530)

* Update readme.java.md to make Resource.resourcegroup readonly

* Update readme.java.md

* Update readme.java.md to make subscriptionid readonly
Copy link

Hi @JonathanGiles, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core.V2 Contains issues to consider when desiging Azure Core V2 Azure.Core azure-core breaking-change Client This issue points to a problem in the data-plane of the library. compat breaks
Projects
Azure Core V2
To consider
Status: Done
Development

No branches or pull requests

2 participants