Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Optimize DAC credential selection #36867

Closed
billwert opened this issue Sep 20, 2023 · 1 comment · Fixed by #38404
Closed

[FEATURE REQ] Optimize DAC credential selection #36867

billwert opened this issue Sep 20, 2023 · 1 comment · Fixed by #38404
Assignees
@g2vinay
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
2024-02

Comments

@billwert
Copy link
Contributor

DAC (really ChainedTokenCredential) should cache which credential gives it a token first and re-use that on subsequent calls, without re-trying earlier credentials.
@billwert billwert added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Sep 20, 2023
@billwert billwert added this to the 2023-11 milestone Sep 20, 2023
@joshfree joshfree modified the milestones: 2023-11, 2023-12 Oct 3, 2023
@ahsonkhan
Copy link
Member

ahsonkhan commented Nov 29, 2023 •
edited
Loading

FWIW, here's the PR that added credential caching in C++:
Azure/azure-sdk-for-cpp#5142

A clarification on the topic: We had discussed and decided not to cache in ChainedTokenCredential, only in DAC.

@joshfree joshfree modified the milestones: 2023-12, 2024-02 Jan 8, 2024
@g2vinay g2vinay mentioned this issue Jan 22, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@g2vinay g2vinay

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
2024-02
Development

Successfully merging a pull request may close this issue.

Optimize DAC credential selection g2vinay/azure-sdk-for-java
4 participants
@joshfree @billwert @g2vinay @ahsonkhan