Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Blob unit test failures in the dev-bookmark branch #37

Closed
jcookems opened this Issue · 1 comment

3 participants

@jcookems

In the dev-bookmark branch, the following unit tests fail:

  • com.microsoft.windowsazure.services.blob.BlobServiceIntegrationTest
    • getBlobwithIfNoneMatchETagAccessconditionWorks
    • getBlobWithIfModifiedSinceAccessconditionWorks

This issue was introduced with 802e9b0 , where PipelineHelpers.ThrowIfError changed what it considered to be an error from >=300 to >=400. This change is correct, but the getBlob code should consider >=300 as an error, because the server returns a 304 if it cannot give a match for the If-* headers.

A potential fix is to change the BlobRestProxy code to replace

    ThrowIfError(response);

with something like:

    // 304 is returned if the blob requested does not match the If-None-Match, etc. headers.
    if (response.getStatus() >= 300) {
        throw new UniformInterfaceException(response);
    }
@joostdenijs

Since this is a regression from already released code, we need to fix this. Al can you do an investigation/fix it if its easy.

@gcheng gcheng was assigned
@gcheng gcheng was assigned
@gcheng gcheng closed this
@gcheng gcheng was unassigned by jcookems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.