Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate whether from and other properties of table entity query services are supported. Maybe remove non-supported ones. #47

Closed
gcheng opened this issue Apr 9, 2012 · 1 comment
Milestone

Comments

@gcheng
Copy link

gcheng commented Apr 9, 2012

The From property is not used and not defined in the MSDN docs for query. It should be removed.

gchengrepo collab

an hour ago

MSDN documentation says it supports select and filter, with no specificity about whether from is supported or not. Even if it doesn't support right now, leaving it in sdk may still be valuable for future scenarios.

http://msdn.microsoft.com/en-us/library/windowsazure/dd179421.aspx

jcookemsrepo collab

43 minutes ago

I disagree; no code in the SDK is using that property, so it is misleading to keep it in a class where it is implied to be an option, and it is bad practice to have dead code. If we need to, we can add it later.

gchengrepo collab

39 minutes ago

This is an interesting perspective, what about orderby and other properties? My point is that we should be consistent, if we delete from, we should delete others as well. Thoughts?

ogail

4 minutes ago

I understand both of your point of views and for that, I suggest to leave this function with private modifier. By doing this we are not exposing something that's not working and at same time we can turn it to public when they are supported.

@ghost ghost assigned joostdenijs Apr 9, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
@gcheng
Copy link
Author

gcheng commented Feb 21, 2013

from is supported according to this documentation http://msdn.microsoft.com/en-us/library/dd135725.aspx

@gcheng gcheng closed this as completed Feb 21, 2013
jianghaolu added a commit to jianghaolu/azure-sdk-for-java that referenced this issue Sep 6, 2016
3010c5c Merge pull request Azure#52 from jianghaolu/unwrap
c78b9c5 Merge commit '9934126e3d2115bedd890f8226cdf1c2c6d39a48' into unwrap
ac146e8 Fix errors
670b55e Merge pull request Azure#51 from jianghaolu/09062016
b5aa0f4 Remove ServiceResponse<> wrappers in most methods
a55439f fixed page listing for no item lists.
e132607 Remove redundant sync & callback based applys
d0191c7 Merge commit '794b2abafedf65c2052f2a7a5932155662de8ab1' into rx
7fb2d38 Fix socket timeout and parallel creation
2c7a100 Fix checkstyle errors
866a220 Adapt fluent impls to use native observables
e9fa2de Fix pagings with headers
ffc5544 Merge commit 'dc9cf4f0b75ac3672a3e125fa2b905dcab7d46f1' into rx
a1c0ae4 Generated code returns observables
7814d4f Merge commit '65d59d6f659b227b9936911c99f9cd053249af86' into rx
de94443 Merge pull request Azure#49 from Azure/sdk_1026
218ef3a Merge pull request Azure#47 from Azure/sdk_1023
13f7e4b Merge pull request Azure#46 from Azure/sdk_1021
6b54fd6 Merge pull request Azure#44 from Azure/sdk_1015
2572366 Merge branch 'master' of github.com:Azure/azure-sdk-for-java into rx
b8004bc Merge pull request Azure#1023 from anuchandy/fixrawtype
ac5100f Fixing the javadoc error and formatting errors for key vault
9980d1f Fixing a bunch of RawType usages and minor improvments in simplying callback
7c46138 Merge pull request Azure#45 from jianghaolu/autorest_1343

git-subtree-dir: runtimes
git-subtree-split: 3010c5c
jianghaolu added a commit to jianghaolu/azure-sdk-for-java that referenced this issue Feb 27, 2017
3010c5c Merge pull request Azure#52 from jianghaolu/unwrap
c78b9c5 Merge commit '9934126e3d2115bedd890f8226cdf1c2c6d39a48' into unwrap
ac146e8 Fix errors
670b55e Merge pull request Azure#51 from jianghaolu/09062016
b5aa0f4 Remove ServiceResponse<> wrappers in most methods
a55439f fixed page listing for no item lists.
e132607 Remove redundant sync & callback based applys
d0191c7 Merge commit '794b2abafedf65c2052f2a7a5932155662de8ab1' into rx
7fb2d38 Fix socket timeout and parallel creation
2c7a100 Fix checkstyle errors
866a220 Adapt fluent impls to use native observables
e9fa2de Fix pagings with headers
ffc5544 Merge commit 'dc9cf4f0b75ac3672a3e125fa2b905dcab7d46f1' into rx
a1c0ae4 Generated code returns observables
7814d4f Merge commit '65d59d6f659b227b9936911c99f9cd053249af86' into rx
de94443 Merge pull request Azure#49 from Azure/sdk_1026
218ef3a Merge pull request Azure#47 from Azure/sdk_1023
13f7e4b Merge pull request Azure#46 from Azure/sdk_1021
6b54fd6 Merge pull request Azure#44 from Azure/sdk_1015
2572366 Merge branch 'master' of github.com:Azure/azure-sdk-for-java into rx
b8004bc Merge pull request Azure#1023 from anuchandy/fixrawtype
ac5100f Fixing the javadoc error and formatting errors for key vault
9980d1f Fixing a bunch of RawType usages and minor improvments in simplying callback
7c46138 Merge pull request Azure#45 from jianghaolu/autorest_1343

git-subtree-dir: runtimes
git-subtree-split: 3010c5c
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
lenala pushed a commit to lenala/azure-sdk-for-java that referenced this issue Nov 16, 2018
Updating to released API version and package versions
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue Mar 4, 2019
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this issue Mar 21, 2019
[Automatic PR] SDK changes from pull request Azure#1023
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this issue May 30, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants