Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] EventHub distributed tracing: stamp EventHubs info on message spans #7725

Closed
2 tasks done
lmolkova opened this issue Jan 25, 2020 · 2 comments · Fixed by #9539
Closed
2 tasks done

[FEATURE REQ] EventHub distributed tracing: stamp EventHubs info on message spans #7725

lmolkova opened this issue Jan 25, 2020 · 2 comments · Fixed by #9539
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@lmolkova
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently message spans do not have any information about event hub they are being sent to.
It could be discovered by following to the linked 'send' span which has attributes describing EventHubs and entity. So it is not a problem for human beings debugging single trace, but creates a a problem for analysis and visualization tools (such as Azure Monitor).
It is inefficient and hard to build aggregated views such as application map and analyze things like number of messages per send call without information about EventHubs on message.

Describe the solution you'd like
stamp event hub properties on message spans:

  • message_bus.destination: EventHubs entity name
  • peer.address: Fully qualified EventHubs name such as <name>.servicebus.windows.net/

Describe alternatives you've considered
Discover relationships between message and and send span on monitoring tool backend to build aggregated views and metrics. It appears to be expensive (from querying perspective) and contributes to bad performance showing up such views.

Additional context

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Jan 27, 2020
@joshfree joshfree added this to the [2020] March milestone Jan 27, 2020
@joshfree
Copy link
Member

@samvaity could you please pick this up for the next monthly update?

@joshfree joshfree modified the milestones: [2020] March, [2020] April Mar 19, 2020
@joshfree
Copy link
Member

Moving this tracing item to the April release as well

@samvaity samvaity linked a pull request Mar 27, 2020 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants