[Ready for review] Enable updateResourceAsync #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Runtime changes detected. pull request created. CI running: |
|
Runtime changes detected. pull request created. CI running: |
anudeepsharma
approved these changes
Sep 17, 2016
anuchandy
changed the title
jianghaolu
reviewed
Sep 20, 2016
| } | ||
|
|
||
| @Override | ||
| public final Observable<FluentModelT> createAsync() { |
There was a problem hiding this comment.
But createResourceAsync() still needs to be implemented?
There was a problem hiding this comment.
Also, please add
@Override
public abstract Observable<FluentModelT> updateResourceAsync();to reinforcement the implementation of update.
|
Runtime changes detected. pull request created. CI running: |
|
@jianghaolu addressed your comments, please take a look when you get chance. |
|
merging as changes are approved. |
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
[Ready for review] Enable updateResourceAsync
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
[Ready for review] Enable updateResourceAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateableTaskGroup is renamed to createUpdateTaskGroup as the group contains task that can run update action on a resource
Renamed ResourceCreator to ResourceCreatorUpdator and it exposes new method updateResourceAsync
CreatableUpdatableImpl now contains default implementation of CreateAsync and UpdateAsync
CreatableImpl inherites from CreatableUpdatableImpl and adding a new base class AppliableImpl that inherits from CreatableUpdatableImpl
This will enable a resource which is only creatable to extends from CreatableImpl and anything that is applicable only to derive from ApplicableImpl.