-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for review] Regenerated the Batch management apis as swagger is updated. #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8143107
to
9978fe0
Compare
9978fe0
to
70994a6
Compare
56dd30e
to
bf75072
Compare
anuchandy
approved these changes
Sep 20, 2016
lgtm, can be merged once CI passes. |
CI fails with this: 4161[ERROR] /home/travis/build/Azure/azure-sdk-for-java/azure-mgmt-batch/src/main/java/com/microsoft/azure/management/batch/implementation/BatchAccountImpl.java:73:64: Name 'BatchAccountInner' must match pattern '^[a-z][a-zA-Z0-9]*$'. [ParameterName] Huh? |
sounds like a parameter name starts with a capitalized letter instead of small? |
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Fixing a breaking change introduced due to RestClient, manually fixin…
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
[Ready for review] Regenerated the Batch management apis as swagger is updated.
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Fixing a breaking change introduced due to RestClient, manually fixin…
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
[Ready for review] Regenerated the Batch management apis as swagger is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is just generation with new swagger, plus resolved errors accordingly.