Adding api annotations to graph and keyvault #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Runtime changes detected. pull request created. CI running: |
martinsawicki
suggested changes
Sep 21, 2016
| import com.microsoft.azure.management.graphrbac.implementation.ADGroupInner; | ||
| import com.microsoft.azure.management.resources.fluentcore.model.Creatable; | ||
| import com.microsoft.azure.management.resources.fluentcore.model.Wrapper; | ||
|
|
||
| /** | ||
| * An immutable client-side representation of an Azure AD group. | ||
| */ | ||
| @LangDefinition |
There was a problem hiding this comment.
Note we now have a simplified annotations approach: just use @fluent() at the top interface and nothing else is needed. The embedded interfaces will be processed automatically - no need to annotate them (per Alva).
The LangDefinition imports can simply be all removed.
|
Oops? I haven't converted the annotations. |
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Fixing PagedList and adding unit test for ResourcePagedList
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
i'll deal with the annotation updates as part of my overall scrub
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Fixing PagedList and adding unit test for ResourcePagedList
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
i'll deal with the annotation updates as part of my overall scrub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.