Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] Dns Zone fluent implementation #1262

Merged
merged 28 commits into from
Nov 11, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ca954b5
Fluent models for record set and record sets
anuchandy Nov 1, 2016
b3efe16
Adding definition and update stages for various record set models
anuchandy Nov 1, 2016
d60b6f4
extending record sets collection interface from various operation int…
anuchandy Nov 1, 2016
3551fb6
Adding dns manager and couple of impls
anuchandy Nov 2, 2016
8e643a0
Implementing recordset Impls
anuchandy Nov 2, 2016
c4d4e90
Implementing definition-stages for all recordsets types
anuchandy Nov 2, 2016
93b4140
adding recordsets impl types
anuchandy Nov 2, 2016
b19b0cf
Merge branch 'master' of github.com:Azure/azure-sdk-for-java into dns…
anuchandy Nov 2, 2016
9d9610c
Some checkstyle fixes
anuchandy Nov 2, 2016
9a607f6
Adding definition stages in DnsRecordSet interface
anuchandy Nov 3, 2016
6b203e4
Adding record sets collection readable entry points to Dns zone
anuchandy Nov 3, 2016
1b663ba
implementing def and update stages in DnsRecordSetImpl
anuchandy Nov 4, 2016
bacce7c
Clear collections after add or remove during update
anuchandy Nov 4, 2016
321a2c8
Removing def and update interfaces from record set interfaces as they…
anuchandy Nov 4, 2016
c996db6
cleaning up SoaRecordSetImpl
anuchandy Nov 4, 2016
8611d9b
renaming merge -> prepareUpdate, expose Soa attribute setters
anuchandy Nov 4, 2016
048fc07
Enable non-inline child resource CUD as part of parent CU
anuchandy Nov 5, 2016
f549fee
override childResourceKey in DnsRecordSetImpl
anuchandy Nov 5, 2016
1957874
removing duplicate initialization of inner properties
anuchandy Nov 5, 2016
3d51208
Enables external child resources to support both inline and non-inlin…
anuchandy Nov 5, 2016
7397b5b
Revert Resource.java changes
anuchandy Nov 5, 2016
1bcabee
Setting default record set ttl and adding unit test
anuchandy Nov 6, 2016
c8167e9
Some cleanup
anuchandy Nov 6, 2016
f35aa33
Update unit tests and fixes
anuchandy Nov 7, 2016
51db91a
covering few more cases in unit test
anuchandy Nov 7, 2016
4c0136a
Exposing recordSet::tags getter
anuchandy Nov 7, 2016
1379191
Revert RecordSet::tags -> RecordSet::metadata
anuchandy Nov 8, 2016
0783930
Adding missing UpdateDefinitionStages. prefix
anuchandy Nov 8, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.batch.Application;
import com.microsoft.azure.management.batch.ApplicationPackage;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesImpl;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesCachedImpl;

import java.util.List;
import java.util.Map;
Expand All @@ -22,7 +22,7 @@
*/
@LangDefinition
class ApplicationPackagesImpl extends
ExternalChildResourcesImpl<ApplicationPackageImpl,
ExternalChildResourcesCachedImpl<ApplicationPackageImpl,
ApplicationPackage,
ApplicationPackageInner,
ApplicationImpl,
Expand All @@ -34,7 +34,7 @@ class ApplicationPackagesImpl extends
super(parent, "ApplicationPackage");
this.client = client;
this.parent = parent;
this.initializeCollection();
this.cacheCollection();
}

public ApplicationPackageImpl define(String name) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.batch.Application;
import com.microsoft.azure.management.batch.BatchAccount;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesImpl;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesCachedImpl;

import java.util.ArrayList;
import java.util.Collections;
Expand All @@ -23,7 +23,7 @@
*/
@LangDefinition
class ApplicationsImpl extends
ExternalChildResourcesImpl<ApplicationImpl,
ExternalChildResourcesCachedImpl<ApplicationImpl,
Application,
ApplicationInner,
BatchAccountImpl,
Expand All @@ -35,7 +35,7 @@ class ApplicationsImpl extends
super(parent, "Application");
this.client = client;
this.applicationPackagesClient = applicationPackagesClient;
this.initializeCollection();
this.cacheCollection();
}

public Map<String, Application> asMap() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import com.microsoft.azure.management.compute.VirtualMachine;
import com.microsoft.azure.management.compute.VirtualMachineExtension;
import com.microsoft.azure.management.resources.fluentcore.arm.ResourceUtils;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesImpl;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.implementation.ExternalChildResourcesCachedImpl;

import java.util.ArrayList;
import java.util.Collections;
Expand All @@ -14,11 +14,11 @@
* Represents a extension collection associated with a virtual machine.
*/
class VirtualMachineExtensionsImpl extends
ExternalChildResourcesImpl<VirtualMachineExtensionImpl,
VirtualMachineExtension,
VirtualMachineExtensionInner,
VirtualMachineImpl,
VirtualMachine> {
ExternalChildResourcesCachedImpl<VirtualMachineExtensionImpl,
VirtualMachineExtension,
VirtualMachineExtensionInner,
VirtualMachineImpl,
VirtualMachine> {
private final VirtualMachineExtensionsInner client;

/**
Expand All @@ -30,7 +30,7 @@ class VirtualMachineExtensionsImpl extends
VirtualMachineExtensionsImpl(VirtualMachineExtensionsInner client, VirtualMachineImpl parent) {
super(parent, "VirtualMachineExtension");
this.client = client;
this.initializeCollection();
this.cacheCollection();
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.microsoft.azure.management.dns;

import java.util.List;

/**
* An immutable client-side representation of a A (Ipv4) record set in Azure Dns Zone.
*/
public interface ARecordSet extends DnsRecordSet {
/**
* @return the Ipv4 addresses of A records in this record set
*/
List<String> ipv4Addresses();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.microsoft.azure.management.dns;

import com.microsoft.azure.management.apigeneration.Fluent;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsGettingByName;
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsListing;

/**
* Entry point to A record sets in a Dns zone.
*/
@Fluent
public interface ARecordSets extends
SupportsListing<ARecordSet>,
SupportsGettingByName<ARecordSet> {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.microsoft.azure.management.dns;

import java.util.List;

/**
* An immutable client-side representation of a Aaaa (Ipv6) record set in Azure Dns Zone.
*/
public interface AaaaRecordSet extends DnsRecordSet {
/**
* @return the IPv6 addresses of Aaaa records in this record set
*/
List<String> ipv6Addresses();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.microsoft.azure.management.dns;

import com.microsoft.azure.management.apigeneration.Fluent;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsGettingByName;
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsListing;

/**
* Entry point to Aaaa record sets in a Dns zone.
*/
@Fluent
public interface AaaaRecordSets extends
SupportsListing<AaaaRecordSet>,
SupportsGettingByName<AaaaRecordSet> {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package com.microsoft.azure.management.dns;

/**
* An immutable client-side representation of a CName (canonical name) record set in Azure Dns Zone.
*/
public interface CnameRecordSet extends DnsRecordSet {
/**
* @return the canonical name (without a terminating dot) of CName record in this record set
*/
String canonicalName();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.microsoft.azure.management.dns;

import com.microsoft.azure.management.apigeneration.Fluent;
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsGettingByName;
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsListing;

/**
* Entry point to Cname record sets in a Dns zone.
*/
@Fluent
public interface CnameRecordSets extends
SupportsListing<CnameRecordSet>,
SupportsGettingByName<CnameRecordSet> {
}
Loading