Change 'secret.keys' to 'secret-keys' #15359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrujun
requested review from
jialindai,
saragluna,
yiliuTo and
zhoufenqin
as code owners
ghost
added
the
3 tasks
3 tasks
|
So we did bring breaking changes when we update the property names? We should be more cautious next time to avoid make breaking changes in minor version. |
Yes.
It make sense. |
chenrujun
force-pushed
the
issue-15342
branch
from
da3fcac
to
cd049dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error in document and integration test.