Random features and bug fixes #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsawicki
suggested changes
Oct 5, 2017
| @@ -16,8 +16,10 @@ | |||
| /** Windows Server 2012 R2 Data center. */ | |||
| WINDOWS_SERVER_2012_R2_DATACENTER("MicrosoftWindowsServer", "WindowsServer", "2012-R2-Datacenter"), | |||
| /** Windows Server 2016 technical preview with container support. */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
in addition to the annotation, we can also put in a Javadoc tag @deprecated and say what to do instead (e.g. see ApplicationGatewayBackendHttpConfiguration.java)
…tualMachineImage and KnownWindowsVirtualMachineImage
| /** OpenSUSE-Leap 42.1. */ | ||
| /** | ||
| * OpenSUSE-Leap 42.1. | ||
| * @deprecated use withLatestLinuxImage("SUSE", "openSUSE-Leap", "42.3") instead. |
There was a problem hiding this comment.
when I used the method name without # in the Javadoc, i got a warning in Eclipse. Does javadocs still resolve this reference properly when no # is used? (in other words: #withLatestLinuxImage(...))
There was a problem hiding this comment.
thanks!, updated PR so that these references resolve properly.
martinsawicki
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses -