-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting redirect uri. #21249
Merged
chenrujun
merged 7 commits into
Azure:master
from
han-gao:Enable_property_azure.activedirectory.redirect-uri-template
May 18, 2021
Merged
Support setting redirect uri. #21249
chenrujun
merged 7 commits into
Azure:master
from
han-gao:Enable_property_azure.activedirectory.redirect-uri-template
May 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han-gao
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
May 8, 2021 08:04
stliu
reviewed
May 10, 2021
stliu
reviewed
May 10, 2021
...pring-boot/src/main/java/com/azure/spring/autoconfigure/aad/AADAuthenticationProperties.java
Outdated
Show resolved
Hide resolved
stliu
reviewed
May 10, 2021
...pring-boot/src/main/java/com/azure/spring/autoconfigure/aad/AADAuthenticationProperties.java
Show resolved
Hide resolved
could you link this PR to the github issue? |
han-gao
force-pushed
the
Enable_property_azure.activedirectory.redirect-uri-template
branch
from
May 10, 2021 06:35
4a52e05
to
0d68124
Compare
chenrujun
requested changes
May 11, 2021
sdk/spring/azure-spring-boot-starter-active-directory/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
Hi, @han-gao , please resolve the conflicts. |
…to Enable_property_azure.activedirectory.redirect-uri-template # Conflicts: # sdk/spring/azure-spring-boot/CHANGELOG.md
chenrujun
requested changes
May 18, 2021
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/README.md
Outdated
Show resolved
Hide resolved
chenrujun
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2022
Add alert definition navigation property to alert configuration (Azure#21249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
azure-spring
All azure-spring related issues
azure-spring-aad
Spring active directory related issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features: Support user to set redirect-uri.