-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing serialisation warning on clientSideRequestDiagnostics #23086
Fixing serialisation warning on clientSideRequestDiagnostics #23086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we should use a different ObjectMapper than then one with AfterBurner which is used for data payload serialization for diagnostics serialization. Please check if we are using the same ObjectMapper or different.
see this PR for more context:
https://github.com/Azure/azure-sdk-for-java/pull/20114/files
also if possible for internal types and diagnostics we should rely on customer serializer rather than the ObjectMapper auto discovery of the class structure. see this as example:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/routing/PartitionKeyInternal.java#L35-L36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this change will not fix the issue.
…ew mapper for tracer/feedDiagnostics/cosmospageflux
NetworkCloud 2022-12-12-preview API corrections (Azure#23086) * first public preview version for NetworkCloud APIs * added custom words * added required attribute to payloads to correct aaz-dev-tool CLI generation * corrected console patch API payload * removed invalid child resources list by subscription APIs
Issue -
After burner will throw waring which serialization of package private fields
In ClientSideStatistics class we had some fields which is getting serialized as package private.
Also SystemInfomation was not visible to jackson.
Note: This is only repro on jar which is published to central repo and not the local jar. Will test it on Azure repo before publishing it to maven.
closes #22974