Made UserAgentUtil throw for applicationIds longer than 24 characters.
#23643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them throw when an `applicationId` longer than 24 characters is provided.
vcolin7
requested review from
anuchandy,
jianghaolu,
lmolkova,
mssfang and
pallavit
as code owners
ghost
added
the
sdk/core/azure-core/src/main/java/com/azure/core/util/UserAgentUtil.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/ClientOptions.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Aug 18, 2021
alzimmermsft
approved these changes
Aug 19, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 20, 2023
Update exmaples Stable Folder (Azure#23643) Adding Email argument in Stable folder example. Already done in preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned
UserAgentUtilwithClientOptionsandHttpLogOptionsso it also throws when anapplicationIdlonger than 24 characters is provided. Also updated tests and JavaDocs.