Add jdk default trust manager to KeyVaultTrustManager #23758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @michaelqi793 , if this PR is ready to ready for review, please click |
chenrujun
reviewed
Sep 2, 2021
|
|
||
| /** | ||
| * Stores the keystore. | ||
| * Stores the default trust manager with key vault key store. |
There was a problem hiding this comment.
Can we just keep delete kvTrustManager and otherTrustManager, and make defaultTrustManager use the jreKeyStore?
michaelqi793
requested review from
backwind1233,
moarychan,
saragluna,
stliu,
yiliuTo,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
|
Replaced with #23923 |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 15, 2023
[Hub Generated] Review request for Microsoft.Devices to add version preview/2023-06-30-preview (Azure#23758) * Adds base for updating Microsoft.Devices from version preview/2022-11-15-preview to version 2023-06-30-preview * Updates readme * Updates API version in new specs and examples * rename cosmosdb collection to container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, If we override the JCA trust manager globally by KeyVaultTrustManager, when KeyVaultTrustManager is instantiated, if the passed-in key store is null, then KeyVaultTrustManager will create a KeyVaultKeyStore then use it to initialize JDK default trust manager which then calls the KeyVaultKeyStore's getAliases() method which then needs a TSL connection that also creates new KeyVaultTrustManager... So there is a dead loop. To halt this dead loop:
1 Remove the logic of initializing the JDK default trust manager with KeyVaultKeyStore in KeyVaultTrustManager's constructor
2 Add a global static jdk trust manager initialized with jdk key store
3 Add the logic of using global static trust manager to check server/client side at the first place to block the dead loop.