Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track If Netty Builder Set Resolver and Properly Use Noop Resolver When Proxying #26611

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #26559

This PR resolves an issue where proxying clients aren't able to use the no-op resolver. This can result in request failures if the HttpClient is being used in a network where it isn't allowed to access external resources, therefore fails to resolve the address and subsequently fails the request.

Now, the Netty builder tracks whether it added the default resolver (done to resolve another performance issue) and if it had and a proxy is being used it will appropriate configure the no-op resolver.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. HttpClient labels Jan 21, 2022
@alzimmermsft alzimmermsft self-assigned this Jan 21, 2022
@ghost ghost added the Azure.Core azure-core label Jan 21, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alzimmermsft alzimmermsft enabled auto-merge (squash) January 22, 2022 01:39
@alzimmermsft alzimmermsft merged commit c3d59e5 into Azure:main Jan 22, 2022
@alzimmermsft alzimmermsft deleted the AzNetty_FixHowAddressResolverIsApplied branch April 4, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Blob clients with Netty do not work behind proxy server without accessible DNS server
2 participants