Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a delayed check before decoding the delivery and make sure to handle RejectedExecutionException #27839

Merged
merged 2 commits into from Mar 31, 2022

Conversation

anuchandy
Copy link
Member

@anuchandy anuchandy commented Mar 23, 2022

  1. Do not bypass the exception to the reactor-level-handler, leaving Receiver Sink unterminated
    Fixes Root causing protonj "no current delivery" #27716 (root cause)
    Fixes [BUG] Event hub receiver stops consuming messages from partiton after a few days #24575 (cx issue1)
    Fixes Eventhub - Getting this Unhandled exception while processing events in reactor, report this error. java.lang.IllegalStateException: no current delivery #26975 (cx issue2)
  2. Ensure RejectedExecutionException is handled in all places that use Dispatcher.invoke

…ting other healthy receivers, ensure ExceutionRejectedException is handled in all places that uses Dispatcher.invoke
@anuchandy anuchandy added Event Hubs Service Bus pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) amqp Label for tracking issues related to AMQP labels Mar 23, 2022
@ghost ghost added the Azure.Core azure-core label Mar 23, 2022
@anuchandy anuchandy changed the title Do a delayed check before decoding the delivery and make sure to handle ExceutionRejectedException Do a delayed check before decoding the delivery and make sure to handle RejectedExecutionException Mar 23, 2022
@conniey
Copy link
Member

conniey commented Mar 28, 2022

I am curious why we are merging into this feature branch rather than main?

@anuchandy
Copy link
Member Author

Hi @conniey, Actually, the pr is targetting the main branch.

@anuchandy anuchandy enabled auto-merge (squash) March 31, 2022 16:32
@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-core-amqp

API changes are not detected in this pull request for com.azure:azure-core-amqp

@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-messaging-servicebus

API changes are not detected in this pull request for com.azure:azure-messaging-servicebus

@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-messaging-eventhubs

API changes are not detected in this pull request for com.azure:azure-messaging-eventhubs

@anuchandy anuchandy merged commit 6d827ec into Azure:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amqp Label for tracking issues related to AMQP Azure.Core azure-core Event Hubs pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) Service Bus
Projects
None yet
5 participants