Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable connection state listener by default #28471

Merged
merged 9 commits into from May 18, 2022

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Apr 22, 2022

Task: #28268

Description:
Enable endpointRediscovery(aka. ConnectionStateListener) by default.

BenchmarkTest:

P95 Latency:
image

P99 Latency:
image

P999 Latency:
image

Max Latency:
image

Throughput:
image

@azure-sdk
Copy link
Collaborator

API change check for com.azure:azure-cosmos

API changes are not detected in this pull request for com.azure:azure-cosmos

@xinlian12 xinlian12 changed the title Enable throughput control by default Enable connection state listener by default May 10, 2022
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is missing

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

Azure cosmos pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1576752&view=results

Run the following tests locally:
getSessionTokensInRequests
splitQueryContinuationToken
orderByQueryForLargeCollection
before_MultiOrderByQueryTests

@xinlian12
Copy link
Member Author

check-enforcer override

@xinlian12
Copy link
Member Author

The pipeline has completed based on here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1577257&view=results

@xinlian12
Copy link
Member Author

/check-enforcer override

@xinlian12 xinlian12 merged commit 6507bf4 into Azure:main May 18, 2022
anushkasingh16 pushed a commit to anushkasingh16/azure-sdk-for-java that referenced this pull request Jun 6, 2022
* enable throughput control by default


Co-authored-by: annie-mac <annie-mac@XBX-2505-B09E.redmond.corp.microsoft.com>
Co-authored-by: annie-mac <annie-mac@yindeng2019.fareast.corp.microsoft.com>
Co-authored-by: annie-mac <annie-mac@annie-macs-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants