Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThroughputControlFix - New client item created when enable same group multiple times #28905

Merged
merged 2 commits into from
May 17, 2022
Merged

ThroughputControlFix - New client item created when enable same group multiple times #28905

merged 2 commits into from
May 17, 2022

Conversation

xinlian12
Copy link
Member

Issue:
For global throughput control, If the same group being enabled multiple times, it will cause new group controller being created, which cause new client item being created.

Expected behavior:
If the same group being enabled multiple times, it should reuse the existing group controller.

Fix:
Changed to match the expected behavior.

@ghost ghost added the Cosmos label May 17, 2022
FabianMeiswinkel
FabianMeiswinkel approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - amazing how fast you came up with this fix. I was halfway-there after about 4 hours :-)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

FabianMeiswinkel
FabianMeiswinkel approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entries for both azure-cosmos as well as Spark would be good - can be done in next PR (changing throughput threshodl thought) - which I will need to work on later today

@xinlian12
Copy link
Member Author

LGTM - amazing how fast you came up with this fix. I was halfway-there after about 4 hours :-)

Thanks Fabian, but finding where the issue is is the hardest part >_<

@xinlian12
Copy link
Member Author

Changelog entries for both azure-cosmos as well as Spark would be good - can be done in next PR (changing throughput threshodl thought) - which I will need to work on later today

Updated change log

@FabianMeiswinkel FabianMeiswinkel merged commit ca71030 into Azure:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@milismsft milismsft Awaiting requested review from milismsft milismsft is a code owner

@aayush3011 aayush3011 Awaiting requested review from aayush3011 aayush3011 is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xinlian12 @azure-sdk @FabianMeiswinkel