Mgmt network supports priority

[XiaofeiCao]

Description

1. Upgraded api-version to 2021-08-01.
2. Supported priority in ApplicationGatewayRequestRoutingRule.

Manual code in d365abb

Live Tests passed.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-network
azure-resourcemanager-samples

[XiaofeiCao]

In Samples, jacoco is skipped in pom.xml.

azure-sdk-for-java/sdk/resourcemanager/azure-resourcemanager-samples/pom.xml

Line 39 in 21612b1

<jacoco.skip>true</jacoco.skip>

Running jacoco:aggregate-report on it will fail.

[XiaofeiCao]

skip is probably not the cause of failure, will look more into this.

[weidongxu-microsoft]

error

[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.8:report-aggregate (default-cli) on project azure-sdk-aggregate-coverage: Execution default-cli of goal org.jacoco:jacoco-maven-plugin:0.8.8:report-aggregate failed: malformed input off : 0, length : 1: Input length = 1 -> [Help 1]

will try to solve it within azure-resourcemanager-samples, but might need to add the "exclude" if we do not know what was wrong with the module or jacoco:report-aggregate (the error message is not very helpful).

[weidongxu-microsoft]

This actually works https://stackoverflow.com/a/68232557
However it had to be put to the generated POM.

The cause of problem might be that resourcemanager had some zip/war/jar in the samples (for samples for webapp etc.).

So I think the solution is either exclude azure-resourcemanager-samples, or improve the generated POM to only include the classes we need.

@srnagar

[srnagar]

This exclusion list should not be hard coded. Make this into an argument to the script and update the ci to add this package as an arg when running the script.

[XiaofeiCao]

Sure, sounds good.
On the other hand, Weidong found out the cause is that samples project contains zip/war/jar and jacoco doesn't support them.
He suggests that rather than excluding the samples, we can add

<includes>
   <include>**/*.class</include>
</includes> 

to the jacoco configuration in the pom template (we can do it in this PR). It'll look like:

  <build>
    <plugins>
      <plugin>
        <groupId>org.jacoco</groupId>
        <artifactId>jacoco-maven-plugin</artifactId>
        <version>{}</version>
        <configuration>
          <outputDirectory>target/site/test-coverage</outputDirectory>
          <includes>
             <include>**/*.class</include>
          </includes>
          <excludes>
             <exclude>META-INF/**</exclude>
          </excludes>
        </configuration>
      </plugin>
    </plugins>
  </build>

Either will resolve the issue. Which one do you prefer?