[Cosmos] added client side session token to diagnostics #29516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check API changes are not detected in this pull request. |
simorenoh
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
mbhaskar,
simplynaveen20,
xinlian12,
milismsft and
aayush3011
as code owners
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 17, 2022
...mos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentServiceRequest.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 22, 2022
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Jun 22, 2022
| @@ -283,6 +284,8 @@ public static class StoreResponseStatistics { | |||
| private ResourceType requestResourceType; | |||
| @JsonSerialize | |||
| private OperationType requestOperationType; | |||
| @JsonSerialize | |||
| private String requestSessionToken; | |||
There was a problem hiding this comment.
should we only show when it is not null? @kushagraThapar @FabianMeiswinkel you thoughts here?
xinlian12
reviewed
Jun 22, 2022
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java
Show resolved
Hide resolved
|
/azp run cosmos - java - ci |
|
No pipelines are associated with this pull request. |
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the work for porting the same change that was made in the .NET SDK of adding the request session token to the diagnostics.
.NET: Azure/azure-cosmos-dotnet-v3#3176