Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Normalizer in SimpleField and SearchableField #29542

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Add Support for Normalizer in SimpleField and SearchableField #29542

merged 1 commit into from
Jun 24, 2022

Conversation

alzimmermsft
Copy link
Member

Description

Adds support for normalizers in SimpleField and SearchableField in FieldBuilder.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. labels Jun 17, 2022
@alzimmermsft alzimmermsft self-assigned this Jun 17, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-search-documents

@alzimmermsft alzimmermsft marked this pull request as ready for review June 24, 2022 21:47
@alzimmermsft alzimmermsft merged commit c16508c into Azure:main Jun 24, 2022
@alzimmermsft alzimmermsft deleted the AzSearch_SupportNormilizerInFieldBuilder branch June 24, 2022 22:02
@alzimmermsft alzimmermsft mentioned this pull request Jun 24, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssfang mssfang mssfang approved these changes

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alzimmermsft @azure-sdk @mssfang