-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Support relative path in Polling Strategy #29676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Wait for review from core experts.
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/implementation/PollingUtils.java
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
...e/azure-core/src/main/java/com/azure/core/util/polling/OperationResourcePollingStrategy.java
Show resolved
Hide resolved
sdk/core/azure-core/src/test/java/com/azure/core/util/polling/PollingStrategyTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@alzimmermsft @srnagar for review from core.
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/implementation/PollingUtils.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/implementation/PollingUtils.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/polling/implementation/PollingUtils.java
Outdated
Show resolved
Hide resolved
…implementation/PollingUtils.java Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
Based on the request of #29375
Added the support for relative path in Polling Strategy.