Fixing the SerializationDateTimeConversionMode AlwaysEpochMillisecdsWithSystemDefaultTimezone
#30266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dsWithSystemDefaultTimezone` The `CosmosRowConverter` had a bug assuming that ZoneOffsets between two time zones would be constant - in fact in the 19xx years political rules defining summer/winter time have changed multiple times. To get the correct ZoneOffset the right "local" Instant (vs. Instant.now) needs to be used.
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
mbhaskar,
simplynaveen20,
xinlian12,
milismsft and
aayush3011
as code owners
ghost
added
the
… it possible to save in hdfs as Spark2 continuations
…to users/fabianm/DateTimeConversionInvestigation
FabianMeiswinkel
requested review from
alzimmermsft,
samvaity,
g2vinay and
JimSuplizio
as code owners
kushagraThapar
approved these changes
Aug 4, 2022
...osmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/ChangeFeedOffset.scala
Show resolved
Hide resolved
...rc/main/scala/com/azure/cosmos/spark/udf/CreateSpark2ContinuationsFromChangeFeedOffset.scala
Show resolved
Hide resolved
...rc/main/scala/com/azure/cosmos/spark/udf/CreateSpark2ContinuationsFromChangeFeedOffset.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CosmosRowConverterhad a bug assuming that ZoneOffsets between two time zones would be constant - in fact in the 19xx years political rules defining summer/winter time have changed multiple times. To get the correct ZoneOffset the right "local" Instant (vs. Instant.now) needs to be used.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines