Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Fidelity Change Feed Processor with public surface changes #30399

Conversation

kushagraThapar
Copy link
Member

@kushagraThapar kushagraThapar commented Aug 11, 2022

This PR introduces public surface changes for full fidelity Change Feed Processor.

  • Same ChangeFeedProcessorBuilder which is already GA for incremental mode ->
public ChangeFeedProcessorBuilder handleAllVersionsAndDeletesChanges(Consumer<List<ChangeFeedProcessorItem>> consumer)

  • ChangeFeedProcessorItem -> contains JsonNode current, JsonNode previous and ChangeFeedMetaData metadata

  • ChangeFeedMetaData -> contains long crts, long lsn, ChangeFeedOperationType operationType, long previouslsn, boolean timeToLiveExpired

  • ChangeFeedOperationType -> CREATE, REPLACE and DELETE

  • Deprecated old APIs in ChangeFeedPolicy

    @Beta(value = Beta.SinceVersion.V4_12_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    @Deprecated(since = "V4_37_0", forRemoval = true)
    public static ChangeFeedPolicy createIncrementalPolicy();


   @Beta(value = Beta.SinceVersion.V4_12_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    @Deprecated(since = "V4_37_0", forRemoval = true)
    public static ChangeFeedPolicy createFullFidelityPolicy(Duration retentionDuration);


   @Beta(value = Beta.SinceVersion.V4_12_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    @Deprecated(since = "V4_37_0", forRemoval = true)
    public Duration getFullFidelityRetentionDuration();
    
  • New APIs added in ChangeFeedPolicy
    @Beta(value = Beta.SinceVersion.V4_37_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    public static ChangeFeedPolicy createAllVersionsAndDeletesPolicy(Duration retentionDuration)

    
    @Beta(value = Beta.SinceVersion.V4_12_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    public static ChangeFeedPolicy createLatestVersionPolicy()


    @Beta(value = Beta.SinceVersion.V4_37_0,
        warningText = Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    public Duration getAllVersionsAndDeletesRetentionDuration()

  • Deprecated APIs in CosmosChangeFeedRequestOptions
    @Beta(value = Beta.SinceVersion.V4_12_0, warningText =
        Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    @Deprecated(since = "V4_37_0", forRemoval = true)
    public CosmosChangeFeedRequestOptions fullFidelity()
  • New APIs added in CosmosChangeFeedRequestOptions
    @Beta(value = Beta.SinceVersion.V4_37_0, warningText =
        Beta.PREVIEW_SUBJECT_TO_CHANGE_WARNING)
    public CosmosChangeFeedRequestOptions allVersionsAndDeletes()

simorenoh and others added 30 commits July 27, 2022 14:41
Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thx!

@kushagraThapar kushagraThapar merged commit 2262467 into Azure:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants