Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ByteBuf Leak during Edge Cases of writeBodyTo #30670

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #30666

Fixes a potential ByteBuf leak when using a non-buffered HttpResponse from NettyAsyncHttpClient. The leak should only occur if there is an error or cancellation while using writeBodyTo . This leak doesn't happen when using writeBodyToAsync as Reactor has built-in handling when the asynchronous stream errors or is cancelled where the synchronous writeBodyTo loses that capability as it leaves asynchronous stream.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Core azure-core label Aug 26, 2022
@chanduram07
Copy link

Hello @alzimmermsft ,Please let me know in which version of the SDK we can expect fix for this bug?

@alzimmermsft
Copy link
Member Author

Hello @alzimmermsft ,Please let me know in which version of the SDK we can expect fix for this bug?

This will be included in the next release once this is merged, which should be some time later this week

@alzimmermsft alzimmermsft merged commit fa9dacc into Azure:main Aug 30, 2022
@alzimmermsft alzimmermsft deleted the AzNetty_FixByteBufLeak branch August 30, 2022 18:55
vcolin7 pushed a commit to vcolin7/azure-sdk-for-java that referenced this pull request Sep 9, 2022
Fixes ByteBuf Leak during Edge Cases of writeBodyTo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure Core] Memory leak on netty-buffer
3 participants