Fixes ByteBuf Leak during Edge Cases of writeBodyTo #30670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30666
Fixes a potential
ByteBuf
leak when using a non-bufferedHttpResponse
fromNettyAsyncHttpClient
. The leak should only occur if there is an error or cancellation while usingwriteBodyTo
. This leak doesn't happen when usingwriteBodyToAsync
as Reactor has built-in handling when the asynchronous stream errors or is cancelled where the synchronouswriteBodyTo
loses that capability as it leaves asynchronous stream.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines