-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mergeMigration #32496
Merged
Merged
mergeMigration #32496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
a3a99b4
to
a8ae9ef
Compare
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
commented
Dec 8, 2022
...main/java/com/azure/cosmos/implementation/changefeed/common/ChangeFeedContextClientImpl.java
Show resolved
Hide resolved
xinlian12
commented
Dec 8, 2022
...c/main/java/com/azure/cosmos/implementation/changefeed/epkversion/LeaseStoreManagerImpl.java
Show resolved
Hide resolved
FabianMeiswinkel
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - looks great!
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Tested the following failed tests locally |
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This change is part of the feature work #32131. In order to support merge (which requires the epk version leases) and align with changeFeedProcessor long term strategy, we introduced a new API handleLatestVersionChanges.
When customer switch from handleChanges to handleLatestChanges, due to the internal lease store switch, if there is no any support, then the changeFeed processing will start from beginning, which could cause high amount duplicate processing, which is not ideal.
Solution
In order to minimize the impact when customer switch API, we added automatic migration support in this PR.
##Previous Main Flow
##Current Main Flow