-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding azure developer credential #32527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
g2vinay,
schaabs,
joshfree and
billwert
as code owners
December 8, 2022 22:40
ghost
added
the
Azure.Identity
label
Dec 8, 2022
API change check APIView has identified API level changes in this PR and created following API reviews. |
billwert
requested changes
Dec 9, 2022
...ntity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/test/java/com/azure/identity/DefaultAzureCredentialTest.java
Show resolved
Hide resolved
g2vinay
reviewed
Jan 30, 2023
...ntity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java
Show resolved
Hide resolved
billwert
reviewed
Jan 30, 2023
sdk/identity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredentialBuilder.java
Outdated
Show resolved
Hide resolved
billwert
approved these changes
Jan 31, 2023
Hello @billwert! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines