Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Support multiple sign in client registrations for Azure AD B2C #33234

Closed
wants to merge 12 commits into from
Closed

[POC] Support multiple sign in client registrations for Azure AD B2C #33234

wants to merge 12 commits into from

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Jan 31, 2023 •
edited

Description

Fixes #29662, see from the feature spec proposal.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Jan 31, 2023
@moarychan moarychan marked this pull request as draft January 31, 2023 08:25
@moarychan moarychan changed the title POC for multiple sign in client registrations [POC] Support multiple sign in client registrations for Azure AD B2C Feb 1, 2023
@moarychan moarychan mentioned this pull request Feb 1, 2023
Open
@moarychan
Address comments
1c410eb
@moarychan
Improve code
d37dfa8
@moarychan
Fix code smells
bb2dbc7
@moarychan
Improve code, add uts
5ebc046
@moarychan
Merge branch 'main' of github.com:Azure/azure-sdk-for-java into moary…
dd84e1b 
…/aad-b2c-multiple-sign-in-poc

# Conflicts:
#	eng/code-quality-reports/src/main/resources/revapi/revapi.json
#	sdk/spring/CHANGELOG.md
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@moarychan
Copy link
Member Author

Temporarily closed.

@moarychan moarychan closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

@mssfang mssfang Awaiting requested review from mssfang mssfang will be requested when the pull request is marked ready for review mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Allow multiple ClientRegistrations for Azure AD B2C
3 participants
@moarychan @azure-sdk @saragluna