Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miscellaneousUpdate-2 #35360

Merged
merged 2 commits into from
Jun 8, 2023
Merged

miscellaneousUpdate-2 #35360

merged 2 commits into from
Jun 8, 2023

Conversation

xinlian12
Copy link
Member

  1. update spark change log
  2. Update sessionTokenMismatchMaximumBackoffTime from 50ms to 500ms - ported change from .Net SDK https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/pullrequest/478564

@github-actions github-actions bot added the Cosmos label Jun 7, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

FabianMeiswinkel
FabianMeiswinkel approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kushagraThapar
kushagraThapar requested changes Jun 8, 2023
View reviewed changes
sdk/cosmos/azure-cosmos-spark_3-3_2-12/CHANGELOG.md Outdated
@@ -5,6 +5,7 @@
#### Features Added

#### Breaking Changes
* Addressed `NullPointerException` in `CosmosDataItemSource` constructor when Spark runtime initialization hasn't completed yet. - See [PR 35201](https://github.com/Azure/azure-sdk-for-java/pull/35201)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a breaking change??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - it should be in bug fix section. Updated

kushagraThapar
kushagraThapar approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks @xinlian12 !!

@kushagraThapar kushagraThapar merged commit 1436755 into Azure:main Jun 8, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@milismsft milismsft Awaiting requested review from milismsft milismsft is a code owner

@aayush3011 aayush3011 Awaiting requested review from aayush3011 aayush3011 is a code owner

@simorenoh simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

@jeet1995 jeet1995 Awaiting requested review from jeet1995 jeet1995 is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinlian12 @azure-sdk @kushagraThapar @FabianMeiswinkel