Fixed stale minConnectionPoolSizePerEndpoint config. #36599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jeet1995
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh and
Pilchie
as code owners
kushagraThapar
approved these changes
Aug 31, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConnectionPolicy.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
CosmosClient/CosmosAsyncClientinitialization to read the latest value set on system property -COSMOS.MIN_CONNECTION_POOL_SIZE_PER_ENDPOINTwhen creating min pool size no. of connections for a given endpoint used by a container for which proactive connection management is enabled.The
minConnectionPoolSizePerEndpointset onContainerDirectConnectionMetadata(container-level settings) &DirectConnectionConfig(client-level settings) will be compared against the latest valueCOSMOS.MIN_CONNECTION_POOL_SIZE_PER_ENDPOINTsystem property to determine connection pool size for the endpoint belonging to a given container.