-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevCenter DataPlane v2023-04-01 stable SDK from TypeSpec with Convinience API #37766
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
Hi @drielenr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @drielenr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any test is changed and used, make sure you move them out of generated
package (files within could be overwritten during codegen).
If the target is GA, we need higher test coverage that this azure-sdk-for-java/sdk/devcenter/azure-developer-devcenter/pom.xml Lines 41 to 42 in c1e3a45
Preferable one test case for every REST API. |
...ter/src/samples/java/com/azure/developer/devcenter/custom/CreatesOrUpdatesAnEnvironment.java
Outdated
Show resolved
Hide resolved
...eloper-devcenter/src/test/java/com/azure/developer/devcenter/custom/CreatesADevBoxTests.java
Outdated
Show resolved
Hide resolved
Your current coverage appears to be good. You probably can remove this 2 lines in pom. |
You may want to link to the apiview that you use for Arch board review. |
I am OK with the PR (doc, sample, test). But I didn't review the API as there is no current apiview. |
Description
We currently have a beta SDK targeting DevCenter 2023-04-01 API, and this PR is to have it released as a stable SDK - our first stable release, targeting same API.
Both SDKs (the last one released and this one) were generated from TypeSpec. The main change introduced was add model generation and updates on tests and samples to reflect that addition.
Arch board meeting occurred but APIView is not yet approved.
Link to the original api view here
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Pipeline runs
Dry runs on the release pipeline:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5622&_a=summary
List of tests
DevBox
DevCenter
Environments
Also updated samples.