Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevCenter DataPlane v2023-04-01 stable SDK from TypeSpec with Convinience API #37766

Merged
merged 48 commits into from
Apr 16, 2024

Conversation

drielenr
Copy link
Member

@drielenr drielenr commented Nov 22, 2023

Description

We currently have a beta SDK targeting DevCenter 2023-04-01 API, and this PR is to have it released as a stable SDK - our first stable release, targeting same API.

Both SDKs (the last one released and this one) were generated from TypeSpec. The main change introduced was add model generation and updates on tests and samples to reflect that addition.

Arch board meeting occurred but APIView is not yet approved.
Link to the original api view here

All SDK Contribution checklist:

  • The pull request does not introduce breaking changes
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Pipeline runs

Dry runs on the release pipeline:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5622&_a=summary

List of tests

DevBox

  • get_pool
  • list_pools
  • get_dev_box
  • get_remote_connection
  • get_action
  • list_actions
  • skip_action
  • delay_action
  • delay_all_actions
  • get_schedule
  • list_schedules
  • list_dev_boxes
  • list_all_dev_boxes
  • list_all_dev_boxes_by_user
  • begin_create_dev_box
  • begin_delete_dev_box
  • begin_start_dev_box
  • begin_stop_dev_box
  • begin_restart_dev_box

DevCenter

  • get_project
  • list_projects

Environments

  • begin_delete_environment
  • begin_create_or_update_environment
  • list_environment_types
  • list_catalogs
  • list_environments
  • list_all_environments
  • get_environment_definition
  • list_environment_definitions
  • list_environment_definitions_by_catalog
  • get_catalog
  • get_environment

Also updated samples.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-developer-devcenter

Copy link

github-actions bot commented Feb 2, 2024

Hi @drielenr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Feb 2, 2024
Copy link

github-actions bot commented Feb 9, 2024

Hi @drielenr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Feb 9, 2024
@drielenr drielenr reopened this Apr 2, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Apr 2, 2024
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any test is changed and used, make sure you move them out of generated package (files within could be overwritten during codegen).

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Apr 3, 2024

If the target is GA, we need higher test coverage that this

<jacoco.min.linecoverage>0.18</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>0.11</jacoco.min.branchcoverage>

Preferable one test case for every REST API.

@weidongxu-microsoft
Copy link
Member

If the target is GA, we need higher test coverage that this

<jacoco.min.linecoverage>0.18</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>0.11</jacoco.min.branchcoverage>

Preferable one test case for every REST API.

Your current coverage appears to be good.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=3666151&view=codecoverage-tab

You probably can remove this 2 lines in pom.

@weidongxu-microsoft
Copy link
Member

Arch board meeting occurred but APIView is not yet approved.

You may want to link to the apiview that you use for Arch board review.

@weidongxu-microsoft
Copy link
Member

I am OK with the PR (doc, sample, test). But I didn't review the API as there is no current apiview.

@drielenr drielenr merged commit 6b2fa98 into main Apr 16, 2024
33 checks passed
@drielenr drielenr deleted the drielene/generate-with-models branch April 16, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants