New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cosmos-spark: release 2024-03-12 - Reducing noisy logs in WARN but adding more verbose logs when retries have been re-enqueued. #39169

Merged

FabianMeiswinkel merged 4 commits into Azure:main from FabianMeiswinkel:users/fabianm/BulkWriterInvestigation

Mar 12, 2024

Member

FabianMeiswinkel commented Mar 12, 2024 •

edited

Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.


          azure-cosmos-spark: Reducing noisy logs in WARN but adding more verbo…

ac0aef5

…se logs when retries have been re-enqueued.

FabianMeiswinkel requested review from kushagraThapar, kirankumarkolli, xinlian12, milismsft, aayush3011, simorenoh, jeet1995 and Pilchie as code owners

March 12, 2024 01:28

github-actions bot added the Cosmos label

Collaborator

azure-sdk commented Mar 12, 2024

API change check

API changes are not detected in this pull request.

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/BulkWriter.scala Outdated Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/BulkWriter.scala Outdated Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/BulkWriter.scala Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/BulkWriter.scala Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/BulkExecutor.java Outdated Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/BulkExecutor.java Show resolved Hide resolved

xinlian12 reviewed

View reviewed changes

sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/BulkWriter.scala Show resolved Hide resolved

xinlian12 approved these changes

View reviewed changes

Member

xinlian12 left a comment

LGTM, thanks

FabianMeiswinkel added 3 commits

March 12, 2024 04:23


          Reacting to code review feedback

817937e


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

b1f8ff1

…to users/fabianm/BulkWriterInvestigation


          Changelogs

229aeec

FabianMeiswinkel requested review from alzimmermsft, samvaity, g2vinay and JimSuplizio as code owners

March 12, 2024 04:43

FabianMeiswinkel changed the title ~~azure-cosmos-spark: Reducing noisy logs in WARN but adding more verbose logs when retries have been re-enqueued.~~ azure-cosmos-spark: release 2024-03-12 - Reducing noisy logs in WARN but adding more verbose logs when retries have been re-enqueued.

Member Author

FabianMeiswinkel commented Mar 12, 2024

/azp run java - cosmos - spark

azure-pipelines bot commented Mar 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel merged commit bb072ec into Azure:main

43 checks passed

drielenr pushed a commit that referenced this pull request


          azure-cosmos-spark: release 2024-03-12 - Reducing noisy logs in WARN …

2d3745a

…but adding more verbose logs when retries have been re-enqueued. (#39169)

* azure-cosmos-spark: Reducing noisy logs in WARN but adding more verbose logs when retries have been re-enqueued.

* Reacting to code review feedback

* Changelogs

kushagraThapar mentioned this pull request

Lower levels of two log statements #40833

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xinlian12 xinlian12 approved these changes

kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

milismsft Awaiting requested review from milismsft milismsft is a code owner

aayush3011 Awaiting requested review from aayush3011 aayush3011 is a code owner

simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

jeet1995 Awaiting requested review from jeet1995 jeet1995 is a code owner

Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

alzimmermsft Awaiting requested review from alzimmermsft

samvaity Awaiting requested review from samvaity

g2vinay Awaiting requested review from g2vinay

JimSuplizio Awaiting requested review from JimSuplizio