Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channelAcquisitionExceptionForWrites #39255

Merged
merged 2 commits into from
Mar 19, 2024
Merged

channelAcquisitionExceptionForWrites #39255

merged 2 commits into from
Mar 19, 2024

Conversation

xinlian12
Copy link
Member

Issue:
For write operation failed with ChannelAcquisition timeout exception, no cross region retry is attempted.

Fix:

  • Using ChannelAcquisitionException for channel acquisition timeout situation
  • Extends ChannelAcquisitionException of ChannelException
  • ChannelException is retriableException, which will be retried by ClientRetryPolicy

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

FabianMeiswinkel
FabianMeiswinkel approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

Tested locally for the following tests:
readFeedDocumentsAfterSplit
readFeedDocumentsAfterSplit_maxScaleCount
createItem_withBulk_split
createItem_withCacheRefresh

@xinlian12
Copy link
Member Author

tryGetAddress_repeatedlySetUnhealthyStatus_forceRefresh - flaky tests

@xinlian12
Copy link
Member Author

/check-enforcer override

1 similar comment
@xinlian12
Copy link
Member Author

/check-enforcer override

@xinlian12 xinlian12 merged commit 01522dd into Azure:main Mar 19, 2024
68 of 73 checks passed
drielenr pushed a commit that referenced this pull request Apr 2, 2024
@xinlian12 @drielenr
channelAcquisitionExceptionForWrites (#39255)
5f1a4bd 
* channelAcquisitionException fix

---------

Co-authored-by: annie-mac <xinlian@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@milismsft milismsft Awaiting requested review from milismsft milismsft is a code owner

@aayush3011 aayush3011 Awaiting requested review from aayush3011 aayush3011 is a code owner

@simorenoh simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

@jeet1995 jeet1995 Awaiting requested review from jeet1995 jeet1995 is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xinlian12 @azure-sdk @FabianMeiswinkel