mgmt, support convenience API for publicNetworkAccess in Vault #39309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
added
the
Mgmt
weidongxu-microsoft
changed the title
3 tasks
weidongxu-microsoft
requested review from
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
| * | ||
| * @return whether the vault can be accessed from public network. | ||
| */ | ||
| PublicNetworkAccess publicNetworkAccess(); |
There was a problem hiding this comment.
I thought about using boolean publicNetworkAccessEnabled() (as 1. it is two-value; 2. other service may not have the enum), but use this to be consistent with Registry and ManagedHsm.
XiaofeiCao
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #39192
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines