KafakV2SourceConnector #39410
Merged
KafakV2SourceConnector #39410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 6, 2024 18:22
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
FabianMeiswinkel
approved these changes
Mar 28, 2024
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
xinlian12
force-pushed
the
KafkaV2SourceConnector-2
branch
from
87f96bb
to
10f8bca
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
force-pushed
the
KafkaV2SourceConnector-2
branch
from
b518c1f
to
6a25454
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lmolkova
reviewed
Mar 28, 2024
| /*** | ||
| * The CosmosDb source connector. | ||
| */ | ||
| public class CosmosDBSourceConnector extends SourceConnector { |
There was a problem hiding this comment.
should it implement AutoCloseable?
There was a problem hiding this comment.
yea good point, will add in the next PR
|
flaky tests: tests passed locally: |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add kafka source v2 connector #38748 and #38884
Extra changes added(mainly to reduce the export packages scope from azure-cosmos):
Added the following methods in azure-cosmos (internal and can be accessed from ImplementationBridgeHelpers).
CosmosChangeFeedRequestOptions:CosmosAsyncContainer: