Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized the partitioning strategy implementation details to avoid unnecessarily high RU usage #39438

Conversation

FabianMeiswinkel
Copy link
Member

Description

This PR optimizes some of the partitioning strategy values to reduce chance that RU-consumption for queries or change feed requests is unnecessarily high when no EPK filtering is enabled for an account. Functionally using Spark partitions scoped to subsets of physical partitions is possible to increase parallelization but it comes with an overhead of increase RU usage - and in many cases that is unnecessary. So, this PR avoids this from happening in most cases (unless partition merge happened) for all partitioning strategies except for Aggressive and Custom.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however, I am wondering if this is a breaking change? And should we explicitly call it out in the changelog instead of calling it out as optimized?

@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FabianMeiswinkel FabianMeiswinkel merged commit ed43699 into Azure:main Apr 2, 2024
35 checks passed
xinlian12 pushed a commit to xinlian12/azure-sdk-for-java that referenced this pull request Apr 10, 2024
… avoid unnecessarily high RU usage (Azure#39438)"

This reverts commit ed43699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants