Make Blackbird & Afterburner be dynamically added to the ObjectMapper #39689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphillips-ms
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @daphillips-ms! We will review the pull request and get back to you soon. |
daphillips-ms
changed the title
daphillips-ms
force-pushed
the
daphillips/makeAfterburnerOptional
branch
2 times, most recently
from
2c2a044
to
ae6d7de
Compare
daphillips-ms
requested review from
alzimmermsft,
samvaity,
g2vinay,
JonathanGiles,
chenrujun,
Netyyyy,
saragluna and
moarychan
as code owners
daphillips-ms
force-pushed
the
daphillips/makeAfterburnerOptional
branch
5 times, most recently
from
255f06e
to
7be1d33
Compare
|
/azp run java - cosmos - tests |
daphillips-ms
requested review from
juntuchen-msft,
cochi2,
minwoolee-msft,
skapur12,
wiboris,
dpwatrous,
NickKouds,
anilba06,
gkostal,
LarryOsterman and
a team
as code owners
daphillips-ms
requested review from
sarangan12,
pvaneck,
KevinBlasko,
gracewilcox,
srnagar,
ToddKingMSFT,
gulopesd,
maorleger,
ahsonkhan and
mpodwysocki
daphillips-ms
force-pushed
the
daphillips/makeAfterburnerOptional
branch
from
eb9ec2c
to
c2693d3
Compare
…pending on Java version and existence in classpath
daphillips-ms
force-pushed
the
daphillips/makeAfterburnerOptional
branch
from
c2693d3
to
ecc04e1
Compare
|
Rebased on the latest main. Added description line under 4.58.0 in CHANGELOG.md |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Manually triggered test pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3712868&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...depending on Java version and existence in classpath
Description
We are using the Dropwizard framework which creates it's own ObjectMappers with this logic:
"If AfterburnerModule" is in the class path, then register it"
... however, Cosmos requires Afterburner to be in the classpath, as it depends on it. This leads to a bit of a conundrum for us.
This changes things such that Afterburner is only registered when it's in the classpath and < Java16, and secondly, Blackbird is loaded instead if > Java11, as it's the preferred way now.
Instead of the CosmosDB having a dependency on Afterburner and Blackbird, it now has an optional, runtime dependency.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines