KafkaConfigRename #39761
Merged
KafkaConfigRename #39761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
kushagraThapar
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM @xinlian12
However, there are places where we can be more clear. Also, for some of the advanced concepts like bulk / patch / etc. we should add documentation to make sure customers understand the concepts as these are not cosmos db native sdk customers.
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-kafka-connect/doc/configuration-reference.md
Outdated
Show resolved
Hide resolved
added 2 commits
April 24, 2024 12:32
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kushagraThapar
approved these changes
Apr 24, 2024
added 4 commits
April 24, 2024 15:57
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename the config name based on reviews